health check API 에서 db connection 확인 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davin111
commented
Aug 2, 2023
|
|
||
| let router = ExpressPromiseRouter(); | ||
|
|
||
| router.get('/health-check', (req, res) => res.sendStatus(200)); | ||
| router.get('/health-check', (req, res) => { | ||
| if (mongoose.connection.readyState !== 1) { |
There was a problem hiding this comment.
밑에서 ping 하는데 이걸 굳이 왜 했지? 싶을 수 있는데.
애당초 최초 connection 부터 망가져 있는 경우에는, 밑에 mongoose.connection.db 쪽에서 TypeError: Cannot read property 'method' of undefined 에러가 발생하고, 이것이 읽기 좋지 않아 본질을 흐리기에 미리 체크하고 가는 것.
mongoose.connection.readyState의 경우에는 ping 과 달리 별도의 db 자원을 소모하지 않음.
davin111
force-pushed
the
health-check-ping
branch
from
64f088d
to
dd056cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wafflestudio.slack.com/archives/C0PAVPS5T/p1690977225130339
k8s liveness probe 가 호출하는 GET /health-check API 에서 db 연결도 체크하도록 함. 로컬에서 실제로 db 정상 연결될 때, 안 될 때 각각 200, 500 잘 반환하는 것 확인함.